From: Rui Matos Date: Mon, 8 Apr 2013 14:04:25 +0000 (+0200) Subject: shellEntry: Remove close method X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~4352 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=07053c3df79fc387d246192c4a18c8503e96fc83;p=gnome-shell.git shellEntry: Remove close method GrabHelper already takes care of putting the key focus back on the widget that had it when the grab was established. ShellEntry's close() has recently become harmful since it's now called from the menu's destroy() method and that is called in the entry's destroy handler which means that this._entry might no longer be valid at close() time. https://bugzilla.gnome.org/show_bug.cgi?id=697560 --- diff --git a/js/ui/shellEntry.js b/js/ui/shellEntry.js index 2256af070..e9a94a692 100644 --- a/js/ui/shellEntry.js +++ b/js/ui/shellEntry.js @@ -82,11 +82,6 @@ const EntryMenu = new Lang.Class({ this.actor.grab_key_focus(); }, - close: function(animate) { - this._entry.grab_key_focus(); - this.parent(animate); - }, - _updateCopyItem: function() { let selection = this._entry.clutter_text.get_selection(); this._copyItem.setSensitive(!this._entry.clutter_text.password_char &&